[Xfce-bugs] [Bug 11764] New: [Patch] Broken xflock4 functionality

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=11764

            Bug ID: 11764
           Summary: [Patch] Broken xflock4 functionality
    Classification: Xfce
           Product: Xfce4-session
           Version: Unspecified
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: xfce-bugs at xfce.org
          Reporter: tpaulic at hotmail.com
        QA Contact: bjt23 at cornell.edu
                CC: benny at xfce.org, nick at xfce.org

Created attachment 6131
  --> https://bugzilla.xfce.org/attachment.cgi?id=6131&action=edit
Patch to bypass null/blank LockCommand parameter

Commit
http://git.xfce.org/xfce/xfce4-session/commit/?id=e940818853582290af21bf38d73ee26143d500ad
breaks xflock4 functionality if the xfconf LockCommand parameter doesn't exist
or is a blank entry. The

$lock_cmd >/dev/null 2>&1 && exit

will run a blank (empty string) and then exist, never getting to the other
items in the list.

The fix is to prepend to that command a check to see if the variable is blank:

if [ ! -z "$lock_cmd" ]; then
   $lock_cmd >/dev/null 2>&1 && exit
fi  

Patch attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.