[Xfce-bugs] review requested: [Bug 11339] Add support for logind hybrid sleep when closing lid : [Attachment 5941] Rebased patch

[bugzilla-daemon at xfce.org]

Steve Dodier-Lazaro <sidnioulz at gmail.com> has asked  for review:
Bug 11339: Add support for logind hybrid sleep when closing lid
https://bugzilla.xfce.org/show_bug.cgi?id=11339

Attachment 5941: Rebased patch
https://bugzilla.xfce.org/attachment.cgi?id=5941&action=edit



--- Comment #1 from Steve Dodier-Lazaro <sidnioulz at gmail.com> ---
Created attachment 5941
  --> https://bugzilla.xfce.org/attachment.cgi?id=5941&action=edit
Rebased patch

Hey Nico,

Thanks for your patch. I've rebased it against current Git.

I have some questions for you: 

1. in xfpm-xfconf.c, why is it that suspend/hibernate are not yet installed but
you install HYBRID_SLEEP? Could it be that there is a better time to install
this value to the property of lid-related actions later? How are suspend and
hibernate added right now?

2. in xfpm_settings_on_ac, you originally did not expose hybrid sleep. Was that
an omission or was there a reason I'm missing? My patch adds it.

3. if I select hybrid sleep on the "System" tab, "System sleep mode" line, I
get:

(xfce4-power-manager:6940): GLib-GObject-WARNING **: value "5" of type 'guint'
is invalid or out of range for property 'inactivity-sleep-mode-on-battery' of
type 'guint'

(xfce4-power-manager:6940): GLib-GObject-WARNING **: value "5" of type 'guint'
is invalid or out of range for property 'inactivity-sleep-mode-on-ac' of type
'guint'

Thanks.