[Xfce-bugs] [Bug 10373] libxfce4ui-4.11: 3bb8c7d breaks shortcuts with <Super> modifier

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=10373

--- Comment #7 from Harald Judt <h.judt at gmx.at> ---
Sorry, my last comment might not have been very helpful. Another attempt:

> Isn't that just how the UI displays all shortcuts?
It is, but the way it does without what I call the hack seems to be the right
one, that is:

<a> => a
<shift>+<a> => A
<super>+<a> => Super + a
<super>+<shift>+<a> => Super + A

"The hack" - you might call it "workaround" - works, and I've been using it
happily for over a year now. However, I do not believe it is the proper
solution. The proper solution would be to find out what causes the mod4/super
modifier to not be recognized correctly. So, as a result of such a proper
solution, we should see the above correct GTK presentation of shortcuts with
correct functionality.

On the other hand, the hack might be necessary, even with these optical
aberrations. Because another complication here might be the difference between
the presentation and parsing that presentation. Note that there are other
exceptions that had to be made, see bug #8744:

  /* If Shift was used when translating the keyboard state, we remove it
   * from the consumed bit because gtk_accelerator_{name,parse} fail to
   * handle this correctly. This allows us to have shortcuts with Shift
   * as a modifier key (see bug #8744). */
  if ((modifiers & GDK_SHIFT_MASK) && (consumed & GDK_SHIFT_MASK))
    consumed &= ~GDK_SHIFT_MASK;

You will notice that these keyboard shortcut grabber bugs are my favourites ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.