[Xfce-bugs] [Bug 10217] Xflock4 doesn't knows about actual lockers

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=10217

Guido Berhoerster <gber at opensuse.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gber at opensuse.org

--- Comment #19 from Guido Berhoerster <gber at opensuse.org> ---
Eric, the script from this bug that you just pushed to git is totally broken,
in particular its guesswork of the running screensaver. pidof is not
universally available (on my SUSE system it comes from Linux sysvinit) and it
cannot be safely used this way. It even has a potential security impact, if
multiple users are logged in and they are running different screensavers the
locking can fail.

Frankly, I think the xflock4 script is utter crap and broken by design. It
would be both simpler, safer and a lot more sane to replace it with a xfconf
setting for a command that is executed synchronously to lock the screen,
possibly even with a small delay as to ensure the screen is locked before
sleep/hibernate and not immediately after wakeup as it is now.
It should probably be preconfigured to xscreensaver-command since xfce4-session
already has a preference for xscreensaver supplying an autostart file for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.