[Xfce-bugs] [Bug 10373] New: libxfce4ui-4.11: 3bb8c7d breaks shortcuts with <Super> modifier

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=10373

            Bug ID: 10373
           Summary: libxfce4ui-4.11: 3bb8c7d breaks shortcuts with <Super>
                    modifier
    Classification: Xfce
           Product: Libxfce4ui
           Version: Unspecified
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: nick at xfce.org
          Reporter: h.judt at gmx.at
                CC: xfce-bugs at xfce.org

http://git.xfce.org/xfce/libxfce4ui/commit/?id=e56596a37ffdb4fe8fda4491466e6f826270accc:

>From e56596a37ffdb4fe8fda4491466e6f826270accc Mon Sep 17 00:00:00 2001
From: Jérôme Guelfucci <jeromeg at xfce.org>
Date: Tue, 18 Dec 2012 07:21:03 +0000
Subject: Improve key comparison.

Remove horrible hardcoded hack and use the recommanded way of comparison
described in the GDK documentation instead.

--

I gave the 4.11 a try and am now suffering from this bug:

Steps to reproduce:
1) Assign a command "a" to a key e.g. XF86Sleep.
2) Assign a command "b" to that same key but with <Super> modifier:
<Super>XF86Sleep.

The settings dialog handles and shows these assignments correctly, and using
xfce4-settings-editor, one can confirm that these assignments are correctly
saved.

3a) Hit XF86Sleep.
3b) Hit <Super>XF86Sleep.

Expected results:
In case 3a), command "a" is executed.
In case 3b), command "b" is executed.

Actual results:
In both cases 3a) and 3b), command "a" is executed.

DBG[xfce-shortcuts-provider.c:288] xfce_shortcuts_provider_property_changed():
property = /commands/custom/<Super>XF86Calculator
TRACE[xfce-shortcuts-grabber.c:311] xfce_shortcuts_grabber_grab(): Grabbing
<Mod4><Super>XF86Calculator
TRACE[xfce-shortcuts-grabber.c:315] xfce_shortcuts_grabber_grab(): Keyval:
269025053
TRACE[xfce-shortcuts-grabber.c:316] xfce_shortcuts_grabber_grab(): Modifiers:
0x4000040
TRACE[xfce-shortcuts-grabber.c:355] xfce_shortcuts_grabber_grab(): Keycode: 148


TRACE[xfce-shortcuts-grabber.c:519] xfce_shortcuts_grabber_event_filter():
Looking for XF86Calculator
...
TRACE[xfce-shortcuts-grabber.c:449] find_event_key(): Comparing to
<Super>XF86Calculator
TRACE[xfce-shortcuts-grabber.c:457] find_event_key(): Positive match for
<Super>XF86Calculator
...
TRACE[xfce-shortcuts-grabber.c:457] find_event_key(): Positive match for
XF86Calculator

Note how the grabber didn't respect our <Super> key.


The same works fine with the <Shift> key:

DBG[xfce-shortcuts-provider.c:288] xfce_shortcuts_provider_property_changed():
property = /commands/custom/<Shift>XF86Calculator
TRACE[xfce-shortcuts-grabber.c:311] xfce_shortcuts_grabber_grab(): Grabbing
<Shift>XF86Calculator
TRACE[xfce-shortcuts-grabber.c:315] xfce_shortcuts_grabber_grab(): Keyval:
269025053
TRACE[xfce-shortcuts-grabber.c:316] xfce_shortcuts_grabber_grab(): Modifiers:
0x1
TRACE[xfce-shortcuts-grabber.c:355] xfce_shortcuts_grabber_grab(): Keycode: 148

TRACE[xfce-shortcuts-grabber.c:519] xfce_shortcuts_grabber_event_filter():
Looking for <Shift>XF86Calculator
...
TRACE[xfce-shortcuts-grabber.c:449] find_event_key(): Comparing to
<Shift>XF86Calculator
TRACE[xfce-shortcuts-grabber.c:457] find_event_key(): Positive match for
<Shift>XF86Calculator
...



And here is the old grabber version:
TRACE[xfce-shortcuts-grabber.c:526] xfce_shortcuts_grabber_event_filter():
Looking for <Hyper><Super>XF86Calculator

-- 
You are receiving this mail because:
You are on the CC list for the bug.