[Xfce-bugs] [Bug 8792] Wrong behavior while stopping gpg-agent without ssh support

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=8792

--- Comment #2 from Yves-Alexis Perez <corsac at debian.org> ---
In my opinion, the handling should be done like :

if !/startup/gpg-agent/enabled || /startup/gpg-agent/enabled == true;
   if !GPG_AGENT_INFO || (GPG_AGENT_INFO && GPG_AGENT_INFO points to garbage);
      run gpg-agent
      remember/export environment
      remember gpg-agent was run
      # ssh-agent mode of gpg-agent should be handled in .gnupg/gpg-agent.conf
      # but in case it's not, handling it here might work
   fi
fi

if !/startup/ssh-agent/enabled || /startup/ssh-agent/enabled == true;
    if !SSH_AGENT_PID || (SSH_AGENT_PID && SSH_AGENT_PID points to garbage);
    # if gpg-agent has been started in ssh-agent mode just above, 
    # SSH_AGENT_PID will be set. same thing if it has been started by another   
    # script
       run ssh-agent
       remember/export environment
       remember ssh-agent was run
    fi
fi

What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.