[Xfce-bugs] [Bug 8718] New: [patch] gpg-agent isn't started/killed when user shell is not sh

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=8718

          Priority: Medium
            Bug ID: 8718
          Assignee: xfce-bugs at xfce.org
           Summary: [patch] gpg-agent isn't started/killed when user shell
                    is not sh
          Severity: normal
    Classification: Xfce
                OS: All
          Reporter: tijl at coosemans.org
          Hardware: All
            Status: NEW
           Version: 4.8.2
         Component: General
           Product: Xfce-utils

Created attachment 4335
  --> https://bugzilla.xfce.org/attachment.cgi?id=4335&action=edit
patch

Xfce runs gpg-agent (when available) from an xinitrc script. The commands
gpg-agent returns depend on the user's shell. When you run gpg-agent from an sh
script you must pass the --sh flag to make sure it returns sh commands. There
are similar flags for ssh-agent and dbus-launch which the xinitrc script
already uses.

I've attached a patch that fixes this. The patch also improves the kill command
for gpg-agent by extracting the pid from the GPG_AGENT_INFO environment
variable. The variable has 3 colon-separated fields. The second is the pid.

-- 
You are receiving this mail because:
You are the assignee for the bug.