[Xfce-bugs] review granted: [Bug 3545] No option to make file executable in permissions tab : [Attachment 3866] Patch v2

[bugzilla-daemon at xfce.org]

Alex Henrie <alexhenrie24 at gmail.com> has granted  review:
Bug 3545: No option to make file executable in permissions tab
https://bugzilla.xfce.org/show_bug.cgi?id=3545

Attachment 3866: Patch v2
https://bugzilla.xfce.org/attachment.cgi?id=3866&action=edit

------- Additional Comments from Alex Henrie <alexhenrie24 at gmail.com>
Okay. Here is a new (less ambitious) patch that only adds
"application/x-ms-dos-executable" and "application/x-msi" to the list. I didn't
have any trouble executing these kinds of files by double-clicking, perhaps
because they opened with WINE.

To test the behavior with .bin files, I downloaded RealPlayer11GOLD.bin from
realplayer.softonic.com. The output of "file RealPlayer11GOLD.bin" was:

RealPlayer11GOLD.bin: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV),
dynamically linked (uses shared libs), for GNU/Linux 2.2.5, not stripped

I found that Thunar considers this file to have the MIME type
"application/octet-stream". This is (to my knowledge) the most generic MIME
type there is, so I don't think you'd want to add it to the list. Perhaps a
more sophisticated system than looking at the MIME type is needed. For now I
would be content with just adding the two Windows file types mentioned above.