[Xfce-bugs] [Bug 8079] New: Memory leak in keyboard shortcut code

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=8079

             Bug #: 8079
           Summary: Memory leak in keyboard shortcut code
    Classification: Xfce
           Product: Libxfce4ui
           Version: Unspecified
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
        AssignedTo: nick at xfce.org
        ReportedBy: fourdan at xfce.org
                CC: xfce-bugs at xfce.org


Created attachment 3923
  --> https://bugzilla.xfce.org/attachment.cgi?id=3923
Fix a memleak in xfce_shortcuts_provider_get_shortcuts()

Valgrind gives:

==31203== 2,252 bytes in 52 blocks are definitely lost in loss record 2,559 of
2,652
==31203==    at 0x4C2649D: malloc (vg_replace_malloc.c:236)
==31203==    by 0x8C90600: g_malloc (gmem.c:164)
==31203==    by 0x8CA71F4: g_strconcat (gstrfuncs.c:327)
==31203==    by 0x5463F4B: ??? (in /usr/lib64/libxfce4kbd-private-2.so.0.0.0)
==31203==    by 0x8C79152: g_hash_table_foreach (ghash.c:1326)
==31203==    by 0x5464D5B: xfce_shortcuts_provider_get_shortcuts (in
/usr/lib64/libxfce4kbd-private-2.so.0.0.0)
==31203==    by 0x42EBB0: loadSettings (settings.c:571)
==31203==    by 0x42FA83: reloadScreenSettings (settings.c:954)
==31203==    by 0x83F834D: g_closure_invoke (gclosure.c:767)
==31203==    by 0x84091FF: signal_emit_unlocked_R (gsignal.c:3252)
==31203==    by 0x84129D1: g_signal_emit_valist (gsignal.c:2983)
==31203==    by 0x8412B71: g_signal_emit (gsignal.c:3040)

Patch attached - Please apply in both branches, master and xfce-4.8

-- 
Configure bugmail: https://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.