[Xfce-bugs] [Bug 7400] New: [PATCH] new gdm handles GDM_LANG differently

[bugzilla-daemon at xfce.org]

http://bugzilla.xfce.org/show_bug.cgi?id=7400

           Summary: [PATCH] new gdm handles GDM_LANG differently
    Classification: Xfce
           Product: Xfce4-session
           Version: 4.8.0
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
        AssignedTo: xfce-bugs at xfce.org
        ReportedBy: kevin at scrye.com
         QAContact: bjt23 at cornell.edu
                CC: benny at xfce.org


New gdm has GDM_LANG set to "" which confuses xfce4-session, resulting in a
null LANG being set instead of whatever should be in there. 

Downstream report: 

https://bugzilla.redhat.com/show_bug.cgi?id=683941

Simple patch: 

Only use GDM_LANG if not empty

gdm >= 2.91 sets GDM_LANG to an empty string which xfce-session
ends up using, overriding existing good LANG and breaking up utf8 etc.

diff -up xfce4-session-4.8.1/xfce4-session/main.c.gdmlang
xfce4-session-4.8.1/xfce4-session/main.c
--- xfce4-session-4.8.1/xfce4-session/main.c.gdmlang    2011-03-10
15:59:08.000000000 +0200
+++ xfce4-session-4.8.1/xfce4-session/main.c    2011-03-10 15:59:30.000000000
+0200
@@ -103,7 +103,7 @@ setup_environment (void)

   /* this is for compatibility with the GNOME Display Manager */
   lang = g_getenv ("GDM_LANG");
-  if (lang != NULL)
+  if (lang != NULL && strlen (lang) > 0)
     {
       xfce_setenv ("LANG", lang, TRUE);
       xfce_unsetenv ("GDM_LANG");

-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.