[Xfce-bugs] [Bug 7196] New: Logout dialog shouldn't call gtk_icon_theme_load_icon() with GTK_ICON_LOOKUP_GENERIC_FALLBACK

[bugzilla-daemon at xfce.org]

http://bugzilla.xfce.org/show_bug.cgi?id=7196

           Summary: Logout dialog shouldn't call
                    gtk_icon_theme_load_icon() with
                    GTK_ICON_LOOKUP_GENERIC_FALLBACK
    Classification: Xfce
           Product: Xfce4-session
           Version: 4.8.0
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
        AssignedTo: xfce-bugs at xfce.org
        ReportedBy: mrpouit at gmail.com
         QAContact: bjt23 at cornell.edu
                CC: benny at xfce.org


Created attachment 3430
  --> http://bugzilla.xfce.org/attachment.cgi?id=3430
Proposed patch

Hi,

The logout dialog calls gtk_icon_theme_load_icon() with the GtkIconLookupFlags
set to GTK_ICON_LOOKUP_GENERIC_FALLBACK. According to the gtk+ doc, it has the
following meaning: "Try to shorten icon name at '-' characters before looking
at inherited themes.".

If I take the reboot button as an example: first, "system-reboot" is tried, and
if not found, "xfsm-reboot" is used. However, when "system-reboot" doesn't
exist, GTK_ICON_LOOKUP_GENERIC_FALLBACK will make gtk+ try "system" first,
which exists, but isn't related at all to the reboot. ;-)

So in the logout dialog, GTK_ICON_LOOKUP_GENERIC_FALLBACK should be replaced by
0, otherwise the "xfsm-*" fallback icons are never used (because "system"
exists in almost all icon themes).

I attached an (untested) patch to fix that.

You might also want to check the icon names used: AFAIK, "system-reboot" is not
the correct icon name, it should be "system-restart"...

Thanks!

-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.