[Xfce-bugs] [Bug 7100] New: xfce-spawn.c g_warning about setting marshaller twice

[bugzilla-daemon at xfce.org]

http://bugzilla.xfce.org/show_bug.cgi?id=7100

           Summary: xfce-spawn.c g_warning about setting marshaller twice
    Classification: Xfce
           Product: Libxfce4ui
           Version: 4.7.6
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
        AssignedTo: nick at xfce.org
        ReportedBy: dannym at xfce.org
                CC: xfce-bugs at xfce.org


When using the xfce_spawn* functions, there will be a runtime warning about
setting the marshaller twice because in file xfce-spawn.c line 157 (i.e. within
xfce_spawn_startup_watch()) there is code to set a hardcoded C marshaller for
the GClosure. Short-term, I suggest to change it to:

if(G_CLOSURE_NEEDS_MARSHAL(spawn_data->closure))
      g_closure_set_marshal (spawn_data->closure,
g_cclosure_marshal_VOID__INT);

... which should keep backwards compability with existing callers.

Long-term, I suggest to review the semantics of the file and ensure that
setting a marshaller on a user-supplied closure is actually valid, i.e. whether
GClosure is actually designed to be used that way.

-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.