[Xfce-bugs] [Bug 6073] xinitrc replaces gnome-keyring SSH_AUTH_SOCK with ssh-agent

[bugzilla-daemon at xfce.org]

http://bugzilla.xfce.org/show_bug.cgi?id=6073

--- Comment #6 from Felipe Contreras <felipe.contreras at gmail.com> 2010-09-16 08:23:50 UTC ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (In reply to comment #2)
> > > > (In reply to comment #1)
> > > > > Hmm, the problem is that there isn't a good way to check that the auth sock is
> > > > > actually valid and isn't a stale env var left over from something else.
> > > > 
> > > > Why is ssh-agent called from there in the first place? Shouldn't it be another
> > > > service in /etc/xdg/autostart?
> > > 
> > > autostart is too late in the startup process. It has to be a parent of
> > > xfce4-session so every child inherits the SSH_AUTH_SOCK and SSH_AGEN_PID
> > > envvar.
> > 
> > Nope, GNOME starts the keyring through autostart, but of course you would have
> > to register Xfce as a session manager in dbus, and listen for when environment
> > variables are requested to be updated.
> > 
> > http://live.gnome.org/SessionManagement/GnomeSession
> 
> Yes, as you know xfce4-session doesn't support this. So my point still stands,
> autostart is too late in the process.

I know what is the status-quo; my point is that it *should* be done with
autostart. This would be the most extensible way, and would help autostart
scripts that require this.

> > The only other sane option is to make it a configuration directly in the
> > preferences, so that the user can choose between gnome compat's keyring, or
> > ssh-agent.
> 
> That's already the case. If you select “Start gnome services at startup”, then
> gnome-keyring is run. In 4.6 it uses the old api though, so I doesn't work
> correctly. But there are patches to make it start correctly and replace
> ssh-agent.
> 
> See http://bugzilla.xfce.org/show_bug.cgi?id=5912

Yes, I am also aware of that. But I still think starting ssh-auth in
/etc/xdg/xfce4/xinitrc is wrong, it should be left to other layers to do that;
either gdm (like it happens on Fedora), /etc/xdg/autostart/ssh-agent.desktop
which would need dbus session support, or in xfce4-session itself just like
gnome-keyring is run right now (as an option).

Alternatively, /etc/xdg/xfce4/xinitrc could read a configuration file somewhere
that specifies whether or not ssh-aent should be run.

-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.