[Xfce-bugs] [Bug 5887] Add support for -Bsymbolic-functions to LD checks

[bugzilla-daemon at xfce.org]

http://bugzilla.xfce.org/show_bug.cgi?id=5887

--- Comment #12 from Jannis Pohlmann <jannis at xfce.org> 2009-10-22 10:28:34 UTC ---
(In reply to comment #11)
> Honestly, why bother?  We're talking about a tiny tiny tiny reduction in binary
> size and a probably negligible performance increase, and the risk is breaking
> things in unknown ways by using a linker flag that clearly we don't completely
> understand.
> 
> The visibility and alias stuff is a little annoying, but it's a known quantity
> and is something well-used by other projects... and we already have (had?) it
> set up.

AFAIK, we've always had it for thunar-vfs, exo and thunarx. We recently removed
it from thunarx and from exo. Nick just added it back to exo.

The aliasdef stuff is kinda ugly but since we're planning to keep the .symbols
file around anyway, I guess it'd be ok to add it back to thunarx as well and
continue to use it.

> If you really want to find ways to increase performance, profile your app and
> fix bottlenecks.  Unless I see real-world benchmarks showing that
> -Bsymbolic-functions actually has a material effect on performance, I don't see
> a reason to use it.

I'm wondering about this, too. The GLib guys told me that PLT lookups and
relocations are a real concern to them which is why they are stuffing
everything into GIO nowadays instead of separate GLib modules. But they
couldn't back this argument up with numbers either.

-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.