[Xfce-bugs] [Bug 5377] libxfce4gui session-client bug fixes, improvements, and some optimizations

[bugzilla-daemon at xfce.org]

http://bugzilla.xfce.org/show_bug.cgi?id=5377





--- Comment #7 from Brian J. Tarricone <bjt23 at cornell.edu>  2009-05-21 18:31:31 UTC ---
(In reply to comment #6)

> OK then:
> 
> 1. interact_2 remains, but will only be used if interact style != none &&
> interact = NULL.
> 
> 2. client_session_new() appends --display-id, for compatibility;
> set_clone_restart_commands() does not.
> 
> 3. set_clone_restart_command() appends --sm-client-id to the restart command
> if missing.
> 
> 4. set_clone_restart_command() removes --sm-client-id, from the clone
> command, no matter if derived by the restart command or set by the user.
> 
> I'll upload it when ready.

Sounds good to me.

> > Currently the session client will attempt to 'do the right thing'
> 
> Not 100% - the current (unpatched) set_clone_restart_command() won't remove
> --sm-client-id from the clone command, and will copy the clone command (if
> missing) from the restart command 1:1, including --sm-client-id. Thus, xfwm4
> and xfdesktop clone commands currently contain client id. In version 4.4.2,
> xfce4-panel had it as well.

Right... that's why it has bugs.  In practical matters, it's not so important,
because I'm not aware of a session manager that actually uses CloneCommand,
but...  better to be correct.

FYI, if you're interested to read about some differences in session manager and
client implementations, check out:
http://live.gnome.org/SessionManagement/NotesOnXSMP
Some of it is out of date (xfce4-session 4.6.x fixes a few of the omissions and
bugs there), but it's pretty useful, I think.

-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.