[Xfce-bugs] [Bug 5067] New: Panel launchers have missing icons after 4.4.x to 4.6.0

[bugzilla-daemon at xfce.org]

http://bugzilla.xfce.org/show_bug.cgi?id=5067

           Summary: Panel launchers have missing icons after 4.4.x to
                    4.6.0
           Product: Xfce
           Version: 4.6.0
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: xfce-utils
        AssignedTo: xfce-bugs at xfce.org
        ReportedBy: rw at rlworkman.net
                CC: nick at xfce.org, bugs at da.mcbf.net



Robby Workman <rw at rlworkman.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at xfce.org
            Version|4.5.x (SVN trunk)           |4.6.0

David Mohr <bugs at da.mcbf.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs at da.mcbf.net


At first, I thought this was an issue related to the fact that Rodent is gone
in 4.6.0, and maybe the user-specific config still had references to the Rodent
theme.  kelnos cooked up a patch to the migration script that checked for this
and changed it to Tango or Gnome or whatever else happened to be on the system,
but the missing icons are still present after the upgrade.

I've got a virtual machine snapshotted with xfce-4.4.x and a config with a few
custom launcher icons, and after playing around a bit, I think I see the
problem (or at least part of it):

  (after upgrade to 4.6.0, but before starting it): 
  root at pkgdev:~/.config/xfce4/panel# grep Icon *
  launcher-10.rc:X-XFCE-IconCategory=7
  launcher-12363047061.rc:X-XFCE-IconCategory=5
  (and several more of those, depending on how many panel icons are present)

I'm guessing that those "X-XFCE-IconCategory" numbers map to an actual 
icon in the 4.4.x icon theme, so if the migration script could translate 
that "7" to "icon-name-whatever" and sed s/X-XFCE-IconCategory=/Icon=/g 
on all the launcher-*.rc files, then I think all would be good.

This would *have* to be done on first launch of xfce-4.6, and there's no 
way to retroactively fix them for users who have already started 4.6 and 
logged off; the entire X-XFCE-IconCategory line is deleted on session 
logout.

  (after logging off):
  root at pkgdev:~/.config/xfce4/panel# grep Icon *
  root at pkgdev:~/.config/xfce4/panel#

-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.