[Xfce-bugs] [Bug 4583] Uniformisation of test method

[bugzilla-daemon at xfce.org]

http://bugzilla.xfce.org/show_bug.cgi?id=4583





--- Comment #1 from Brian J. Tarricone <bjt23 at cornell.edu>  2008-11-06 21:12:27 UTC ---
No, this patch is completely wrong.

1.  It removes the test of DBUS_SESSION_BUS_ADDRESS to ensure a bus isn't
already running.

2.  It removes the use of 'eval', so the new environment variables don't get
propagated into the shell.

Did you even test this?  There's no way it can work.

Really, there's no reason to change how it is now, except maybe to use 'type -p
dbus-launch' instead of 'which dbus-launch', esp since 'which' differs in its
output on different platforms when it fails to find an executable.

(Also: xinitrc gets generated from xinitrc.in; no need to patch them both.)

-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.