[Xfce-bugs] [Bug 4716] New: xdt-commit: Fix detection of changed ChangeLog files, do not rely on grep -P, and prefix changelog entries with directory

[bugzilla-daemon at xfce.org]

http://bugzilla.xfce.org/show_bug.cgi?id=4716

           Summary: xdt-commit: Fix detection of changed ChangeLog files,
                    do not rely on grep -P, and prefix changelog entries
                    with directory
           Product: Xfce
           Version: 4.5.x (SVN trunk)
          Platform: PC (x86)
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: xfce4-dev-tools
        AssignedTo: xfce-bugs at xfce.org
        ReportedBy: alexander.toresson at gmail.com


Created an attachment (id=2036)
 --> (http://bugzilla.xfce.org/attachment.cgi?id=2036)
xdt-commit patch

The following patch fixes the following problems in the current xdt-commit:

* It does not properly detect changed ChangeLog files in svn, it thinks all
have always changed.
* It relies on grep -P being available, it is not available on at least Debian
and Ubuntu. To fix this I invoke perl instead, as I couldn't find a way of
performing the same thing with my grep.
* At least when committing multiple translation updates, it would simply
concatenate the ChangeLog messages, yielding several identical messages. I
prefix every ChangeLog message with the directory of the ChangeLog, so it would
look like this, for example:

xfce4-panel/trunk/po:
    * sv.po: Swedish translation update (Daniel Nylander)
xfdesktop/trunk/po:
    * sv.po: Swedish translation update (Daniel Nylander)
etc

I imagine this would be the most controversial change this patch introduces. I
imagine it could be improved further (to work well when committing from the
same directory as the ChangeLog resides in; I imagine that would currently
result in .: which is not very pretty).

-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.