[Xfce-bugs] [Bug 1901] Allow XKB configuration through Keyboard Settings plugin.

[bugzilla-daemon at xfce.org]

Do not reply to this email.  To comment on this bug, please visit:
http://bugzilla.xfce.org/show_bug.cgi?id=1901





------- Comment #35 from fourdan at xfce.org  2006-09-12 21:06 UTC -------
Humm, I have mixed feelings about that patch:

- Do you need to recreate the pixmaps every time in
mousekeys_systray_timer_cb(), why not caching them? It's really small
pixmaps...

- Don't you leak the pixbuf? It gets created but never unref'ed every 100 ms.

- I think 250ms might be enough, though I did not try neither values. It's just
that 100ms is well, quite a high frequency for such a functionality.


-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.