[Xfce-bugs] [XFCE 0000132]: xfdesktop, settings, have background image list, close settings, open settings, check 'don't set backdrop' -> crash

[xfce-bugs at xfce.org]

The following bug has been RESOLVED.
=======================================================================
http://bugs.xfce.org/view_bug_page.php?f_id=0000132
=======================================================================
Reporter:                   dannym
Handler:                    kelnos
=======================================================================
Project:                    XFCE
Bug ID:                     0000132
Category:                   general
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     resolved
Resolution:                 fixed
=======================================================================
Date Submitted:             2004-03-06 22:21 GMT
Last Modified:              2004-05-03 06:42 GMT
=======================================================================
Summary:                    xfdesktop, settings, have background image list, close settings, open settings, check 'don't set backdrop' -> crash
Description: 
In xfdesktop I have set a background image list.

I go to settings dialog, Backdrop.

I check the checkbox "Don't set backdrop", and xfdesktop crashes.

(today's cvs)

I tried debugging, but there are too many warnings (much of them point to
real issues), so --enable-debug=full doesn't work... Hence I just report
like that. Sorry.

=======================================================================

-----------------------------------------------------------------------
 kelnos - 2004-04-08 15:16 GMT 
-----------------------------------------------------------------------
danny, are you still seeing this bug?  was it in 4.0.x or in CVS?

-----------------------------------------------------------------------
 dannym - 2004-04-10 14:28 GMT 
-----------------------------------------------------------------------
in cvs, and yes, it still happens, reproducible everytime, fortunately

-----------------------------------------------------------------------
 huysmans - 2004-04-13 14:44 GMT 
-----------------------------------------------------------------------
I can confirm this. It seems to be related to reading/setting the root
window properties. I've had problems with this before and the code is
probably rather flaky. Perhaps some extra gdk_x11_error_trap_push / _pop
(?) are enough to fix it. Perhaps we forget to destroy our own property
when clearing the background.

Just some speculation I'm afraid, I hope it may give you some ideas.

-----------------------------------------------------------------------
 kelnos - 2004-04-13 14:55 GMT 
-----------------------------------------------------------------------
thanks for the pointers, jasper.  i'm going to try to rewrite the
settings-handling code by this weekend (in my efforts to find and squash
the app crashing bug), so i'll keep gdk_x11_error... in mind.

-----------------------------------------------------------------------
 kelnos - 2004-05-03 06:42 GMT 
-----------------------------------------------------------------------
forgot about this... fixed a couple weeks ago.