[Xfce-bugs] [XFCE 0000253]: Again: missing entry in defaults file

[xfce-bugs at xfce.org]

The following bug has been RESOLVED.
=======================================================================
http://bugs.xfce.org/view_bug_page.php?f_id=0000253
=======================================================================
Reporter:                   nick_08150
Handler:                    olivier
=======================================================================
Project:                    XFCE
Bug ID:                     0000253
Category:                   xfwm
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     resolved
Resolution:                 fixed
=======================================================================
Date Submitted:             2004-07-09 14:54 GMT
Last Modified:              2004-07-16 21:13 GMT
=======================================================================
Summary:                    Again: missing entry in defaults file
Description: 
Olivier, sorry for this, but I think there is still an issue with the xfwm4
defaults file. The defaults file in CVS does not contain an entry
'fullscreen_key'. When I run xfwm4 in gdb it complains about not finding
this entry (see below). I also browsed WebCVS to be sure, but maybe there
is something wrong with CVS atm?

missing value for option fullscreen_key

** (xfwm4:30971): WARNING **: xfwm4: Missing values in defaults file

** (xfwm4:30971): WARNING **: xfwm4: Missing data from default files

Program exited with code 01.
=======================================================================

-----------------------------------------------------------------------
 olivier - 2004-07-09 15:06 GMT 
-----------------------------------------------------------------------
Yes, sorry, the message is misleading, the fullscreen_key is defined in the
key definition file...

Can you make sure you don't have a copy of keythemerc in
$HOME/.themes/Default/xfwm4/keythemerc?

Cheers,
Olivier.

-----------------------------------------------------------------------
 kelnos - 2004-07-09 15:13 GMT 
-----------------------------------------------------------------------
this may sound silly, but why is a defaults file required at all?  it's
nice to have as a template for users to modify, but IMHO xfwm4 should have
the defaults hardcoded in the binary to use in the case it can't find a
theme file.

-----------------------------------------------------------------------
 nick_08150 - 2004-07-09 15:17 GMT 
-----------------------------------------------------------------------
ok, the custom keythemerc file was the villain. But I guess it's not good
that a misconfigured user rc-file prevents xfwm4 from starting up at all?
Shouldn't it at least modify it silently or use, like kelnos said, some
hardcoded value?

Thanx!

-----------------------------------------------------------------------
 olivier - 2004-07-09 15:25 GMT 
-----------------------------------------------------------------------
The user is not supposed to change the default values.

-----------------------------------------------------------------------
 nick_08150 - 2004-07-09 15:29 GMT 
-----------------------------------------------------------------------
??? But what is a custom keythemerc good for, then? The user is not
supposed to change files that contain default values (like
/usr/share/themes/Default/xfwm4/keythemerc).

-----------------------------------------------------------------------
 olivier - 2004-07-10 22:05 GMT 
-----------------------------------------------------------------------
A custom keytheme is perfectly okay, as long as it's not called "Default"
;)

-----------------------------------------------------------------------
 huysmans - 2004-07-15 19:09 GMT 
-----------------------------------------------------------------------
This can be closed, right?

-----------------------------------------------------------------------
 olivier - 2004-07-15 20:08 GMT 
-----------------------------------------------------------------------
Dunno. If the custom theme was called "Default", then ok, it's not a bug,
but otherwise it might need some more investigations.

-----------------------------------------------------------------------
 olivier - 2004-07-16 21:13 GMT 
-----------------------------------------------------------------------
Ok, here is what I did:

1) create a theme in my home dir
2) Remove most of the mandatory entries
3) restart xfwm4

It doesn't complain, the default and customized key themes are merged
nicely. So I guess the custom theme was called "Default", that's not a
good idea. No bug here IMO.

-----------------------------------------------------------------------
 olivier - 2004-07-16 21:13 GMT 
-----------------------------------------------------------------------
Resolving. If you disagree, please let us hear your voice :)