[Xfce-bugs] [XFCE 0000057]: xffm cannot browse smb shares

[xfce-bugs at xfce.org]

A BUGNOTE has been added to this bug.
=======================================================================
http://bugs.xfce.org/view_bug_page.php?f_id=0000057
=======================================================================
Reporter:                   jue
Handler:                    edscott
=======================================================================
Project:                    XFCE
Bug ID:                     0000057
Category:                   xffm
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     assigned
=======================================================================
Date Submitted:             2003-12-27 19:43 GMT
Last Modified:              2003-12-30 09:39 GMT
=======================================================================
Summary:                    xffm cannot browse smb shares
Description: 
xffm 4.0.2, samba 3.0.1

while trying to access the smb network xffm hangs and CPU
load raises to 100%. In the status window I can see:

Looking for master browsers ...
XFSAMBA> nmblookup -M -- -

The same setup with 4.0.1 worked fine, if I execute the 
nmblookup command on the commandline, I get the correct
master browser:

$> nmblookup -M -- -
querying __MSBROWSE__ on 192.168.0.255
192.168.0.90 __MSBROWSE__<01>


=======================================================================

-----------------------------------------------------------------------
 edscott - 2003-12-28 16:48 GMT 
-----------------------------------------------------------------------
It could be that the version of samba you are using has a signal handler
attached to sigcont. Please apply this patch in reverse (or copy
libs/tubo.c) from the 4.0.1 tree to the 4.0.2 tree and confirm that
xfsamba4 works (or does not):

diff -u -N -r /usr/home/common/CVS/lunar/xfce_4_0_1/xfce4/xffm/libs/tubo.c
/usr/home/common/CVS/lunar/xfce_4_0_2/xfce4/xffm/libs/tubo.c
--- /usr/home/common/CVS/lunar/xfce_4_0_1/xfce4/xffm/libs/tubo.c	Sat Dec
27 09:10:48 2003
+++ /usr/home/common/CVS/lunar/xfce_4_0_2/xfce4/xffm/libs/tubo.c	Sat Dec
20 16:52:30 2003
@@ -300,6 +300,7 @@
     fork_struct *forkO;
     int status;
     forkO = (fork_struct *) ((long)fork_object);
+    if (kill(forkO->childPID,SIGCONT) == 0) return TRUE;
     waitpid(forkO->childPID, &status, WNOHANG);
     if(WIFEXITED(status))
     {
@@ -537,8 +538,10 @@
     forkO->operate_stdout = NULL;
     forkO->operate_stderr = NULL;
 
-    if(forkO->childPID)
+    if(forkO->childPID){
 	kill(forkO->childPID, SIGTERM);
+	kill(forkO->childPID, SIGKILL);
+    }
     if(cleanup)
 	(*cleanup) ();

-----------------------------------------------------------------------
 jue - 2003-12-29 13:23 GMT 
-----------------------------------------------------------------------
Yep, confirmed. xfsamba4 works if i use tubo.c from the 4.0.1 tree.

-----------------------------------------------------------------------
 edscott - 2003-12-29 16:10 GMT 
-----------------------------------------------------------------------
Perfect. As soon as I do some testing of samba-3.0.1 on FreeBSD I will
update CVS and close the bug. Thanks.

-----------------------------------------------------------------------
 edscott - 2003-12-29 20:09 GMT 
-----------------------------------------------------------------------
Please test with the file uploaded to bugviewer replacing libs/tubo.c to
close bug.

-----------------------------------------------------------------------
 jue - 2003-12-30 09:39 GMT 
-----------------------------------------------------------------------
Yes, works. Thanks.