[Xfc-dev] New XFC version

[Erik Harrison]

On 12/12/06, Auke Kok <sofar at foo-projects.org> wrote:
> Auke Kok wrote:
> > Bo Lorentsen wrote:
> >> Hi ...
> >>
> >> This is a tar ball containing the new code I have made in XFC
> >> (libXFCsourceview) to make it contain the GtkSourceView api. I hope that
> >> all you have to do is configure and make. The changes are a little too
> >> big for a patch, so here is a link to the a dist tar ball.
> >>
> >> Url : http://lue.dk/~bl/xfc-4.3.2.tar.bz2
> >>
> >> This is also my application to become maintainer :-)
> >>
> >> /BL
> >>
> >> Ps.: Please note that this link will only be valid for a short period.
> >
> > some minor nitpicks, that I don't understand:
> >
> > how did the tarball end up being 700.000 bytes larger than 4.3.1? I see many updates to
> > html content, are those supposed to be updated? Also there seems to be a lot of added
> > whitespace (empty lines, trailing whitespace) that doesn't look good.
> >
> > This obscures me to see what really changed in the new release :)
> >
> > Can you post a diff to the -svn trunk? this would help us a lot more, since you won't
> > have to post any of the dist-generated files.
> >
>
> okay, I just overlayed the current svn with your tarball and did a svn diff after svn
> adding (but nothing committed) stuff to my local copy.
>
> Attached is the full diff with regard to the current SVN trunk. Please test this and Bo:
> let me know if it's correct and gives you the proper output.
>
>
> most of the code I looked at looks just fine. Let me know if everyone is OK with Bo
> comitting this to the Xfc trunk himself.
>

I'm not really a C++ hacker, but a cursory overview looks fine to me.
I'm OK with Bo committing this, especially since he seems willing to
wrap the Xfce libraries.

> Cheers,
>
> Auke
>
>
>
> _______________________________________________
> Xfc-dev mailing list
> Xfc-dev at xfce.org
> http://foo-projects.org/mailman/listinfo/xfc-dev
>
>
>
>


-- 
Erik

<@kazin> why does php have 'echo' and 'print'?  Do they do different things?
<Bluefoxicy> kazin:  echo prints in a big empty room