<div dir="auto">Hi Andre, I will probably need to update thunarx-python. I think rabbitvcs might be the only project using it though so it's not too big a deal.</div><div class="gmail_extra"><br><div class="gmail_quote">On Oct 23, 2017 11:02 PM, "André Miranda" <<a href="mailto:andre42m@gmail.com">andre42m@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I would like to announce that the *experimental* work on Thunar Extension Framework (thunarx) has been completed [1].<br>
As previously explained, besides updating to gtk3, I wanted to clean the API from deprecated widgets (GtkAction).<br>
This is the last Request For Comments before I push to master.<br>
<br>
New abstraction class:<br>
ThunarxMenuItem<br>
obs1: based on Nemo and Nautilus extension libs, not sure if its name make much sense, specially from ThunarxRenamers<br>
obs2: maybe ThunarxAction would make more sense, maybe not, but of course the "breakage" would be smaller.<br>
<br>
Provider interfaces affected:<br>
- ThunarxMenuProvider — The interface to extensions that provide additional menu items<br>
- ThunarxPreferencesProvider — The interface to extensions that provide preferences<br>
- ThunarxRenamerProvider — The interface to extensions that provide additional bulk renamers<br>
<br>
Methods changed:<br>
- thunarx_menu_provider_get_file<wbr>_actions -> thunarx_menu_provider_get_file<wbr>_menu_items<br>
- thunarx_menu_provider_get_fold<wbr>er_actions -> thunarx_menu_provider_get_fold<wbr>er_menu_items<br>
- thunarx_menu_provider_get_dnd_<wbr>actions -> thunarx_menu_provider_get_dnd_<wbr>menu_items<br>
- thunarx_preferences_provider_g<wbr>et_actions -> thunarx_preferences_provider_g<wbr>et_menu_items<br>
- thunarx_renamer_get_actions -> thunarx_renamer_get_menu_items<br>
<br>
Plugins/components TODO list (marked items are updated):<br>
[X] thunar-advanced-properties ("apr", bundled with thunar)<br>
[X] thunar-simple-builtin-renamers ("sbr", bundled with thunar)<br>
[X] thunar-sendto-email (bundled with thunar)<br>
[X] thunar-trash-panel-applet ("tpa, bundled with thunar)<br>
[X] thunar-user-customizable-actio<wbr>ns ("uca", bundled with thunar)<br>
[X] thunar-wallpaper-plugin (bundled with thunar)<br>
[ ] thunar-actions-plugin<br>
[X] thunar-archive-plugin (WIP available in [2])<br>
[ ] thunar-media-tags-plugin<br>
[ ] thunar-shares-plugin<br>
[ ] thunar-vcs-plugin<br>
[ ] xfdesktop<br>
[ ] anything else depends on thunarx?<br>
<br>
What I ask:<br>
- review the API changes and how things were renamed<br>
- review how ThunarxMenuItem are internally translated into GtkAction (thunar-util.c:thunar_util_act<wbr>ion_from_menu_item)<br>
- test!<br>
<br>
1 - <a href="https://github.com/andreldm/thunar/tree/gtkaction-replacement" rel="noreferrer" target="_blank">https://github.com/andreldm/th<wbr>unar/tree/gtkaction-replacemen<wbr>t</a><br>
2 - <a href="https://github.com/andreldm/thunar-archive-plugin" rel="noreferrer" target="_blank">https://github.com/andreldm/th<wbr>unar-archive-plugin</a><br>
<br>
Cheers,<br>
Andre Miranda<br>
______________________________<wbr>_________________<br>
Thunar-dev mailing list<br>
<a href="mailto:Thunar-dev@xfce.org" target="_blank">Thunar-dev@xfce.org</a><br>
<a href="https://mail.xfce.org/mailman/listinfo/thunar-dev" rel="noreferrer" target="_blank">https://mail.xfce.org/mailman/<wbr>listinfo/thunar-dev</a><br>
</blockquote></div></div>