[Thunar-dev] Thunarx API changes

[Alex]

For me "gtkaction-replacement"
<https://github.com/andreldm/thunar/tree/gtkaction-replacement>  builds
fine after ./autogen.sh + make + sudo make install
However I have a runtime problem with uca :X
(thunar:20814): thunar-CRITICAL **: thunar_util_action_from_menu_item:
assertion 'THUNARX_IS_MENU_ITEM (item)' failed

(thunar:20814): Gtk-CRITICAL **: gtk_action_get_name: assertion
'GTK_IS_ACTION (action)' failed
Speicherzugriffsfehler

Happens after adding a nonsense user-action (e.g. name: test command:
/bin/ls %f ) and than right-click on some file --> crash
Maybe some pre-check of a method which still tests for GTK_IS_ACTION ?

.. just re-tested with master, does not occur there. Seems to be related
to your branch :F

Cheers,
Alex



...
On 27.10.2017 18:21, André Miranda wrote:
> Sorry for the last incomplete message....
>
> I'm able to build the gtkaction-replacement branch at the work's
> computer, but it also runs Arch Linux.
> I'll try with an Ubuntu VM tonight and compare the GtkAction deprecations.
>
> Cheers,
> Andre Miranda
>
> On Thu, Oct 26, 2017 at 7:59 PM, Adam Plumb <adamplumb at gmail.com
> <mailto:adamplumb at gmail.com>> wrote:
>
>     Hi Andre, I'm having some trouble building the
>     gtkaction-replacement branch from your repo.  I get this error:
>
>     thunar-abstract-icon-view.c:279:90: error:
>     ‘thunar_abstract_icon_view_ui’ undeclared (first use in this
>     function); did you mean ‘thunar_abstract_icon_view_init’?
>        abstract_icon_view->priv->ui_merge_id =
>     gtk_ui_manager_add_ui_from_string (ui_manager,
>     thunar_abstract_icon_view_ui,
>                                                                      
>                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                                                                      
>                             thunar_abstract_icon_view_init
>     thunar-abstract-icon-view.c:279:90: note: each undeclared
>     identifier is reported only once for each function it appears in
>     thunar-abstract-icon-view.c:280:78: error:
>     ‘thunar_abstract_icon_view_ui_length’ undeclared (first use in
>     this function); did you mean ‘thunar_abstract_icon_view_init’?
>                                                                      
>                 thunar_abstract_icon_view_ui_length, &error);
>                                                                      
>                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                                                                      
>                 thunar_abstract_icon_view_init
>
>     I'm also getting a bunch of gtk_action deprecation warnings that
>     aren't showing up on thunar master.  Any thoughts?
>
>     On Wed, Oct 25, 2017 at 9:57 PM, André Miranda <andre42m at gmail.com
>     <mailto:andre42m at gmail.com>> wrote:
>
>         Hello Adam,
>         That would be of great help, let me know if you need anything.
>
>         Cheers,
>         Andre Miranda
>
>
>         On 10/24/2017 09:01 AM, Adam Plumb wrote:
>>         Hi Andre, I will probably need to update thunarx-python. I
>>         think rabbitvcs might be the only project using it though so
>>         it's not too big a deal.
>>
>>         On Oct 23, 2017 11:02 PM, "André Miranda" <andre42m at gmail.com
>>         <mailto:andre42m at gmail.com>> wrote:
>>
>>             I would like to announce that the *experimental* work on
>>             Thunar Extension Framework (thunarx) has been completed [1].
>>             As previously explained, besides updating to gtk3, I
>>             wanted to clean the API from deprecated widgets (GtkAction).
>>             This is the last Request For Comments before I push to
>>             master.
>>
>>             New abstraction class:
>>             ThunarxMenuItem
>>             obs1: based on Nemo and Nautilus extension libs, not sure
>>             if its name make much sense, specially from ThunarxRenamers
>>             obs2: maybe ThunarxAction would make more sense, maybe
>>             not, but of course the "breakage" would be smaller.
>>
>>             Provider interfaces affected:
>>             - ThunarxMenuProvider — The interface to extensions that
>>             provide additional menu items
>>             - ThunarxPreferencesProvider — The interface to
>>             extensions that provide preferences
>>             - ThunarxRenamerProvider — The interface to extensions
>>             that provide additional bulk renamers
>>
>>             Methods changed:
>>             - thunarx_menu_provider_get_file_actions ->
>>             thunarx_menu_provider_get_file_menu_items
>>             - thunarx_menu_provider_get_folder_actions ->
>>             thunarx_menu_provider_get_folder_menu_items
>>             - thunarx_menu_provider_get_dnd_actions ->
>>             thunarx_menu_provider_get_dnd_menu_items
>>             - thunarx_preferences_provider_get_actions ->
>>             thunarx_preferences_provider_get_menu_items
>>             - thunarx_renamer_get_actions ->
>>             thunarx_renamer_get_menu_items
>>
>>             Plugins/components TODO list (marked items are updated):
>>             [X] thunar-advanced-properties ("apr", bundled with thunar)
>>             [X] thunar-simple-builtin-renamers ("sbr", bundled with
>>             thunar)
>>             [X] thunar-sendto-email (bundled with thunar)
>>             [X] thunar-trash-panel-applet ("tpa, bundled with thunar)
>>             [X] thunar-user-customizable-actions ("uca", bundled with
>>             thunar)
>>             [X] thunar-wallpaper-plugin (bundled with thunar)
>>             [ ] thunar-actions-plugin
>>             [X] thunar-archive-plugin (WIP available in [2])
>>             [ ] thunar-media-tags-plugin
>>             [ ] thunar-shares-plugin
>>             [ ] thunar-vcs-plugin
>>             [ ] xfdesktop
>>             [ ] anything else depends on thunarx?
>>
>>             What I ask:
>>             - review the API changes and how things were renamed
>>             - review how ThunarxMenuItem are internally translated
>>             into GtkAction
>>             (thunar-util.c:thunar_util_action_from_menu_item)
>>             - test!
>>
>>             1 -
>>             https://github.com/andreldm/thunar/tree/gtkaction-replacement
>>             <https://github.com/andreldm/thunar/tree/gtkaction-replacement>
>>             2 - https://github.com/andreldm/thunar-archive-plugin
>>             <https://github.com/andreldm/thunar-archive-plugin>
>>
>>             Cheers,
>>             Andre Miranda
>>             _______________________________________________
>>             Thunar-dev mailing list
>>             Thunar-dev at xfce.org <mailto:Thunar-dev at xfce.org>
>>             https://mail.xfce.org/mailman/listinfo/thunar-dev
>>             <https://mail.xfce.org/mailman/listinfo/thunar-dev>
>>
>>
>>
>>         _______________________________________________
>>         Thunar-dev mailing list
>>         Thunar-dev at xfce.org <mailto:Thunar-dev at xfce.org>
>>         https://mail.xfce.org/mailman/listinfo/thunar-dev
>>         <https://mail.xfce.org/mailman/listinfo/thunar-dev>
>
>
>         _______________________________________________
>         Thunar-dev mailing list
>         Thunar-dev at xfce.org <mailto:Thunar-dev at xfce.org>
>         https://mail.xfce.org/mailman/listinfo/thunar-dev
>         <https://mail.xfce.org/mailman/listinfo/thunar-dev>
>
>
>
>     _______________________________________________
>     Thunar-dev mailing list
>     Thunar-dev at xfce.org <mailto:Thunar-dev at xfce.org>
>     https://mail.xfce.org/mailman/listinfo/thunar-dev
>     <https://mail.xfce.org/mailman/listinfo/thunar-dev>
>
>
>
>
> _______________________________________________
> Thunar-dev mailing list
> Thunar-dev at xfce.org
> https://mail.xfce.org/mailman/listinfo/thunar-dev


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.xfce.org/pipermail/thunar-dev/attachments/20171027/cfd81869/attachment.html>