[Thunar-dev] Patch for adding emblem support to thunarx master

[Adam Plumb]

Thanks for your suggestion.  I've modified the patch accordingly and filed a
request on bugzilla at: http://bugzilla.xfce.org/show_bug.cgi?id=6055.

Adam

On Mon, Dec 7, 2009 at 2:11 AM, Brian J. Tarricone <bjt23 at cornell.edu>wrote:

> One little thing because it's an obvious problem:
>
> >    gchar     *(*get_mime_type)       (ThunarxFileInfo *file_info);
> >    gboolean   (*has_mime_type)       (ThunarxFileInfo *file_info,
> >                                       const gchar     *mime_type);
> > -
> > +  void       (*set_emblem)          (ThunarxFileInfo *file_info,
> > +                                     const gchar     *emblem_name);
> >    gboolean   (*is_directory)        (ThunarxFileInfo *file_info);
> >
>
> You can't do this, because it breaks binary compatibility with any
> existing plugins.  You should rename the "reserved0" declaration in the
> struct to your new vfunc to keep the struct the same size and keep all
> the existing members in the same positions.
>
> Otherwise, as YAP said, you should file a feature request on bugzilla
> and attach the patch.
>
>        -brian
> _______________________________________________
> Thunar-dev mailing list
> Thunar-dev at xfce.org
> http://foo-projects.org/mailman/listinfo/thunar-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.xfce.org/pipermail/thunar-dev/attachments/20091207/47879e77/attachment.html>