[Thunar-dev] How to use the eject function

[Tino Keitel]

On Wed, Dec 12, 2007 at 01:18:46 +0100, Tino Keitel wrote:
> On Tue, Dec 11, 2007 at 15:44:36 -0800, Brian J. Tarricone wrote:
> > Tino Keitel wrote:
> > > On Tue, Dec 11, 2007 at 20:31:34 +0100, Benedikt Meurer wrote:
> > >> Tino Keitel wrote:
> > >>> I can confirm that I have no "Eject" button in the shortcuts pane
> > >>> without the patch, and and "Eject" button with the patch.
> > >> Committed. Bug Brian to fix xfdesktop as well.
> > > 
> > > I patched xfdesktop in a minimal way (see the attachment), which lead
> > > to the following inconsistency:
> > > 
> > > In thunar, either "Eject" or "Unmount" is shown in the menu, depending
> > > on thunar_vfs_volume_is_ejectable(). In xfdesktop, both "Eject" and
> > > "Unmount" are shown when thunar_vfs_volume_is_ejectable() returns
> > > "true".
> > > 
> > > What behaviour should be preferred?
> > 
> > Eject.  Feel free to cook up a patch, open a bug on bugzilla, and attach it.
> 
> Done.

Hi Brian,

what do you think about the patch? It does not hurry for Xfce itself,
but the Debian maintainers wait for a comment to decide if this fix can
be included in the 4.4.2 build for Debian.

Regards,
Tino