[Thunar-dev] Enhancement with trash [with PATCH, now conforming to Thunar/trunk/HACKING]

Benedikt Meurer benedikt.meurer at unix-ag.uni-siegen.de
Sat Dec 30 13:31:41 CET 2006


Marcos wrote:
> As I mentioned earlier, I wrote a patch which allows the user remove files directly, instead of
> sending the to the Trash
> 
> On the other hand, I just realized my patch does not conform to the standards expected on
> Thunar/trunk/HACKING. 
> 
> This new patch
> a) also adds a Changelog entry
> b) was created with diff -ur , instead of just diff
> 
> as a colateral effect, it will might give a warning/error on older Thunar (0.5rc2) versions
> because of the changelog will not be the same  entry. 
> 
> Benny, sorry for not doing the right way on first place. It won't happen again.

The patch looks good to me. But I have to agree with others that such a
feature can cause unwanted effects. If Thunar behaves different wrt the
trash, users trying out other distributions on sitting on other people's
desktops might harm their systems.

You could however add the patch to the Wiki so other's interested in
your patch will be able to locate it easily.

> Marcos Diez

Benedikt



More information about the Thunar-dev mailing list