[Thunar-dev] multiple selection in icon view

[Matt McClinch]

Benedikt Meurer wrote:

>Matt McClinch wrote:
>  
>
>>Also, I would suggest making the following changes to 
>>exo_icon_view_button_press_event () :
>>
>>1. Get rid of the if statement on line 2079, making that whole block 
>>unconditional.
>>2. Insert this before line 2081, making the call to 
>>exo_icon_view_unselect_all_internal () conditional:
>>                  if (!(event->state & GDK_CONTROL_MASK))
>>
>>I think this results in better behaviour.  You are certainly welcome to 
>>disagree, or to agree with one and not the other.
>>    
>>
>
>Hm, so you want to merge the new selection with the previous selection
>if Control is pressed in addition to Shift?
>
>  
>
Exactly.  It's what I'm used to, and I'm not just talking about 
Explorer.  I figured it was the accepted function of the control key, 
and this change would make it more consistant both internally and 
externally.  I'm not too concerned about suggestion #1; you must have 
had a reason for deciding to do nothing if the item is already 
selected.  If that's the way you want it, then so be it.  However, other 
users will probably expect the same behaviour that I do.  Also, 
following my advice on this point would make icon view more consistant 
with detailed list view.  As a side note, in detailed list view, 
Control+Shift+Click acts just like an unmodified click, which IMO is 
less than ideal.  I don't know how much can be done about that; I know 
GtkTreeView has its limitations.  Anyway, I'm not too concerned about it 
-- just wanted to throw it out there.

>>Matt
>>    
>>
>
>Benedikt
>
>  
>
Matt