[Thunar-dev] multiple selection in icon view

Matt McClinch mattmcclinch at gmail.com
Sat Apr 8 22:59:03 CEST 2006


Benedikt Meurer wrote:

>Matt McClinch wrote:
>  
>
>>Hi Benny,
>>    
>>
>
>Hey Matt,
>
>  
>
>>Sorry if I wasn't clear about what I was trying to say.  Anyway, this
>>libexo patch fixes the problem as I see it.  I really think this is a
>>better way to describe which files are between the anchor and the cursor.
>>    
>>
>
>I haven't checked Windows Explorer, but the patch makes sense (atleast
>from the implementation's POV). Dunno if this is the best way to
>implement Shift-selection.
>
>Anyway, I'm going to apply the patch if nobody complains.
>
>  
>
>>Matt
>>    
>>
>
>Benedikt
>  
>
Cool, though it looks like you replied to my email containing the older 
patch.  I would encourage you to consider applying the newer patch 
instead.  That may have been what you meant; it's hard to tell.

Also, I would suggest making the following changes to 
exo_icon_view_button_press_event () :

1. Get rid of the if statement on line 2079, making that whole block 
unconditional.
2. Insert this before line 2081, making the call to 
exo_icon_view_unselect_all_internal () conditional:
                  if (!(event->state & GDK_CONTROL_MASK))

I think this results in better behaviour.  You are certainly welcome to 
disagree, or to agree with one and not the other.

Matt



More information about the Thunar-dev mailing list