[Thunar-dev] next step in thunar development

Jeff Franks jcfranks at tpg.com.au
Fri Jun 3 11:38:36 CEST 2005


Benny,

I've been going through thunar.xmi and the layout seems to look good, 
but I do have a question about ThunarView. The name is confusing because 
"View" is usually applied to a physical widget, such as you have done 
with ThunarTreeView and ThunarIconView, but ThunarView is an interface. 
Is it really needed? If so, for consistency wouldn't it be better to 
give it a name that ended in "Model", like ThunarWindowModel or something.

Shouldn't ThunarDesktopView derive from ThunarIconView since it still 
needs to implement all the same basic icon stuff. The only difference is 
that ThunarDesktopView needs to implement icon position and persistence 
data, something appropriate for a derived class to do.

I was looking at ExoIconView and did a diff with GtkIconView.  Since it 
is always best to try and minimize  code bloat - Why did you feel the 
need to re-implement  GtkIconView?  As far as I could see there wasn't a 
great difference. You removed some properties, and a few odd lines of 
code, and replaced all occrrences of GTK and gtk with EXO and exo 
respectively. Is there a good reason yuo did this?

Regards,
Jeff.



More information about the Thunar-dev mailing list