[Goodies-dev] [Bug 14972] met.no sunrise API needs to be updated another time.

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Thu Mar 14 01:38:48 CET 2019


https://bugzilla.xfce.org/show_bug.cgi?id=14972

--- Comment #15 from Andre Miranda <andreldm at xfce.org> ---
Olivier, here are my remarks:

1 - At update_offset, shouldn't "dt" be unref'ed with g_date_time_unref?
2 - parse_timestring can be simplified, too many returns and if/elses
3 - At update_summary_subtitle, date_format is now always the same, any reason
to keep that if/else?
4 - With regards the moon phase, there is the moonphase element under
astrodata->location->time which is a number, representing: 0..25: "waxing
crescent", 25..50: "waxing gibbous", 50..75: "waning gibbous", 75..100: "waning
crescent". No need to use another service, we just need to translate that
number into (translatable) strings.

> It's just feeling, but I feel like update of icon is very long. For example,
> this morning night icon still presents whereas sun was already up.
Strange, did you notice this behavior right after the gtk3 port or just now
with your changes?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Goodies-dev mailing list