[Goodies-dev] [Bug 15771] New: Locations with midnight sun erroneously display the Moon icon

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=15771

            Bug ID: 15771
           Summary: Locations with midnight sun erroneously display the
                    Moon icon
    Classification: Panel Plugins
           Product: Xfce4-weather-plugin
           Version: git
          Hardware: PC (x86_64)
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: hjudt at xfce.org
          Reporter: tiny.lasagna at protonmail.com
                CC: goodies-dev at xfce.org
  Target Milestone: ---

For locations which exhibit midnight sun (i.e. no sunset), the weather panel
plugin erroneously displays the text "The sun never rises today.", which I
suppose is technically correct, but the icon it shows is that of the Moon,
while it should be that of the Sun.

Looking over the source, I've noticed that the default values of
astro->sun_never_rises and astro->sun_never_sets are both set to "true" by
default, because in this case, the sunrise API doesn't appear to provide them,
but the is_night_time function only looks at the former, which results in the
same (night-time) icon being displayed both for locations with midnight sun, as
well as those with polar night.

-- 
You are receiving this mail because:
You are on the CC list for the bug.