[Goodies-dev] [Bug 12124] Patch to make icons change color based on cpu frequency

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=12124

Andre Miranda <andreldm at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreldm at xfce.org

--- Comment #2 from Andre Miranda <andreldm at xfce.org> ---
Created attachment 7989
  --> https://bugzilla.xfce.org/attachment.cgi?id=7989&action=edit
Updated patch

First of all, sorry for the long time it took for someone to review your patch.

Patch updated to this branch (soon to be merged into master):
https://git.xfce.org/users/andre/xfce4-cpufreq-plugin/log/?h=improvements

Here are my considerations:
- gtk_widget_queue_draw was not making any difference, I replaced it by firing
a signal, works but it's a hack
- The icon tinting is nifty, but not perfect:
  - https://i.imgur.com/ukBCw3z.png
  - https://i.imgur.com/kfocv6n.png
  - https://i.imgur.com/dFZzAqb.png
- When need to introduce a checkbox to disable this in the property dialog
- Do not call cpufreq_update_pixmap if the icon is hidden

If you are still interested, let me know.

-- 
You are receiving this mail because:
You are on the CC list for the bug.