[Goodies-dev] [Bug 9594] xfce4-panel-plugin-battery: shows 50%% if no battery found, settings do not work

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Thu Nov 29 17:50:35 CET 2018


https://bugzilla.xfce.org/show_bug.cgi?id=9594

--- Comment #19 from John Lindgren <john at jlindgren.net> ---
It's nothing "wrong with our systems".  The initial label is very clearly set
to '50%%' (cf. my patch 2/2 which changes that to a blank string) and if no
battery is present, the label is never updated.

Look at check_acpi_sysfs() in libacpi.c:

        if ( batt_count == 0 )
        {
#ifdef DEBUG
          printf("DBG:No acpi support for sysfs. Trying procfs...\n");
#endif
                acpi_sysfs = 0;
                return 2;
        }

If there is no battery present, the non-zero return value causes
detect_battery_info() to return FALSE.  Then (apparently by design)
update_apm_status() does not update any of the labels due to this line:

        if(!detect_battery_info(battmon)) return TRUE;

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Goodies-dev mailing list