[Goodies-dev] [Bug 14632] New: wi_linux.c:159]: (style) Suspicious condition

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Sun Aug 26 14:34:57 CEST 2018


https://bugzilla.xfce.org/show_bug.cgi?id=14632

            Bug ID: 14632
           Summary: wi_linux.c:159]: (style) Suspicious condition
    Classification: Panel Plugins
           Product: Xfce4-wavelan-plugin
           Version: unspecified
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: General
          Assignee: goodies-dev at xfce.org
          Reporter: dcb314 at hotmail.com
  Target Milestone: ---

wi_linux.c:159]: (style) Suspicious condition (assignment + comparison);
Clarify expression with parentheses.

Source code is

  if ((result = ioctl(device->socket, SIOCGIWESSID, &wreq) < 0)) {

Maybe better code

  if ((result = ioctl(device->socket, SIOCGIWESSID, &wreq)) < 0) {

wi_linux.c:170]: (style) Suspicious condition (assignment + comparison);
Clarify expression with parentheses.

Duplicate.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Goodies-dev mailing list