[Goodies-dev] [Bug 13853] New: Shows no activity on OpenBSD 6.1

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=13853

            Bug ID: 13853
           Summary: Shows no activity on OpenBSD 6.1
    Classification: Panel Plugins
           Product: Xfce4-netload-plugin
           Version: unspecified
          Hardware: All
                OS: OpenBSD
            Status: NEW
          Severity: major
          Priority: Medium
         Component: General
          Assignee: frivoal at xfce.org
          Reporter: edhynan at gmail.com
        QA Contact: goodies-dev at xfce.org
  Target Milestone: ---

Created attachment 7311
  --> https://bugzilla.xfce.org/attachment.cgi?id=7311&action=edit
patch against panel-plugin/wormulon/openbsd.c

In panel-plugin/wormulon/openbsd.c the code assumes that
(struct sockaddr_dl *)->sdl_data
will be nul terminated.  If that were ever the case, it no longer
is so.   The result is that string comparison with (user provided)
interface name fails; no interface is founs, so there is no
activity displayed.

Attached patch does:
1) change a buffer size as a literal constant to macro IFNAMSIZ.
2) Check that (struct sockaddr_dl *)->sdl_nlen > 0 (as OpenBSD netstat does).
3) Reorder lines so that proper copy is made before comparison, and that 
comparison uses the copy.

With these changes, it works.

Patch made against version 1.3.1 source. (The version field on this
form does not have that entry, so 'unspecified' is selected.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.