[Goodies-dev] [Bug 13940] diskperf-plugin: missing <sys/sysmacros.h> include (fails to build w/ glibc-2.25+)

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=13940

Skunnyk <skunnyk at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |skunnyk at xfce.org
            Version|unspecified                 |git
   Target Milestone|---                         |upcoming

--- Comment #1 from Skunnyk <skunnyk at xfce.org> ---
With glibc 2.26:

devperf.c: In function ‘DevGetPerfData1’:
devperf.c:65:13: warning: In the GNU C Library, "major" is defined
 by <sys/sysmacros.h>. For historical compatibility, it is
 currently defined by <sys/types.h> as well, but we plan to
 remove this soon. To use "major", include <sys/sysmacros.h>
 directly. If you did not intend to use a system-defined macro
 "major", you should undefine it after including <sys/types.h>.
     const int       iMajorNo = major(p_iDevice),
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~   





I can confirm that the patch fix the problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.