[Goodies-dev] [Bug 12975] High CPU usage

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=12975

ivan.middleton at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ivan.middleton at gmail.com

--- Comment #32 from ivan.middleton at gmail.com ---
I've run into this bug, and can confirm that the code introduced in the
following commit is the problem:

https://git.xfce.org/panel-plugins/xfce4-battery-plugin/commit/?id=b2985f36af2d8f62f0d6585c8917f8e920ccddc9

It's very, very bad. Memory usage *and* CPU usage increases linearly as the
process continues running!

When I delete the block of code beginning with

#if GTK_CHECK_VERSION (3, 16, 0)

(including the #else clause, which doesn't compile correctly anymore), things
are much saner. (and the code doesn't seem terribly necessary in the first
place-- only relevant when battery is low?)

I'm quite sure that the css provider thing mentioned above is the culprit (I
discovered this on my own before seeing it had been mentioned here as well). As
mentioned above, it's not a memory leak in the strict sense, but is still an
incredible leak in a practical sense.

Speaking of memory leaks, valgrind says that gdk_rgba_to_string (in that same
block of code) causes a memory leak. Presumably you need to free the string
that it returns.

To make things worse, this version made it into the new Debian stable
(stretch). Get ready for lots of mad folks... :/

-- 
You are receiving this mail because:
You are the QA Contact for the bug.