[Goodies-dev] [Bug 11604] Remove negative sign when temperature is 0° F

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=11604

Steve Dodier-Lazaro <sidnioulz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #7 from Steve Dodier-Lazaro <sidnioulz at gmail.com> ---
Just checked the source code and patch, please note the following:

- The patch should also be applied to DEWPOINT, APPARENT_TEMPERATURE and any
other code path that uses F degrees, for consistency.
- It'd be slower to compare the actual plugin label against -0F and swap it for
0, so I'm fine with the (faster) implementation proposed by Harald, BUT: could
you please add a comment explaining that this + 0.5 is performed so that -0F is
displayed as 0F? So, if someone else needs to modify this code later they know
what this operation was added for.

For the rest it's all good for me.

Cheers,

-- 
You are receiving this mail because:
You are on the CC list for the bug.