[Goodies-dev] [Bug 11250] [PATCH] xfce4-netload-plugin: Fix removing GSources

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=11250

Mike Massonnet <mmassonnet at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #6 from Mike Massonnet <mmassonnet at xfce.org> ---
actually i never triggered that bug, but lets see.

glib actually does exactly this for you while removing a source:

https://git.gnome.org/browse/glib/tree/glib/gmain.c?h=glib-2-32#n1845

sooo, wontfix since it does not sound logical to do the following check twice.

g_source_remove(guint tag)
{
    GSource *source;

    source = g_main_context_find_source_by_id(NULL, tag);
    if (source)
    {
        g_source_destroy(source);
    }
}

-- 
You are receiving this mail because:
You are the QA Contact for the bug.