[Goodies-dev] [Bug 10320] New: Incorrect read of min freq value for CPUs and first read of CPU data from sysfs optimisation

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=10320

            Bug ID: 10320
           Summary: Incorrect read of min freq value for CPUs and first
                    read of CPU data from sysfs optimisation
    Classification: Panel Plugins
           Product: Xfce4-cpufreq-plugin
           Version: unspecified
          Hardware: PC (x86_64)
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: Medium
         Component: General
          Assignee: goodies-dev at xfce.org
          Reporter: jlladono at gmail.com
        QA Contact: frivoal at xfce.org

Created attachment 5131
  --> https://bugzilla.xfce.org/attachment.cgi?id=5131&action=edit
patch correcting a max to a min read and optimizing first read of cpu%i
directories

Hello,

Firstly, I tracked the source code from xfce4-cpufreq-linux.c because
xfce4-cpufreq-plugin was not showing any value for CPU, as the intel freq
governor was enabled and it does not follow standard rules to publish its info
in sysfs (linux kernel 3.11.0-rc7). After disabling it, the plugin shows data.

As a result I found a small bug when reading sysfs for the CPUs, where code
should read 

/sys/devices/system/cpu/cpu%i/cpufreq/scaling_min_freq

(it was reading the max value and should read the min one).


And secondly, I propose a better read of /sys/devices/system/cpu directories.
Now it is reading all directories inside. My proposal is to scan only for
cpu[0-9]* directories.


I attach the patch for both.

Salutacions,
Josep

-- 
You are receiving this mail because:
You are the assignee for the bug.