[Goodies-dev] [Bug 9459] New: Plugin always shows frequency of the last CPU, regardless of settings

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Mon Nov 5 19:19:36 CET 2012


https://bugzilla.xfce.org/show_bug.cgi?id=9459

            Bug ID: 9459
           Summary: Plugin always shows frequency of the last CPU,
                    regardless of settings
    Classification: Panel Plugins
           Product: Xfce4-cpufreq-plugin
           Version: git
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: major
          Priority: Medium
         Component: General
          Assignee: goodies-dev at xfce.org
          Reporter: muellner at math.stanford.edu
        QA Contact: frivoal at xfce.org

The CPUfreq plugin shows always the clock frequency of the last CPU, regardless
of which CPU has been selected in the options. The problem is that the function
cpufreq_update_plugin in xfce4-cpufreq-configure updates the label and tooltip
for all cores, so that the text is always overwritten with the information
about the last core:

    gint i;
    for (i = 0; i < cpuFreq->cpus->len; i++)
    {
        CpuInfo *cpu = g_ptr_array_index (cpuFreq->cpus, i);
        if (cpufreq_update_label (cpu)   == FALSE)
            return FALSE;
        if (cpufreq_update_tooltip (cpu) == FALSE)
            return FALSE;
    }

I suggest something like:

        gint i = cpuFreq->options->show_cpu;
        CpuInfo *cpu = g_ptr_array_index (cpuFreq->cpus, i);
        if (cpufreq_update_label (cpu)   == FALSE)
          return FALSE;
        if (cpufreq_update_tooltip (cpu) == FALSE)
          return FALSE;

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Goodies-dev mailing list