[Goodies-dev] [Bug 9068] Idea: Merge with xfce4-power-manager?

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=9068

--- Comment #4 from Lionel Le Folgoc <lionel at lefolgoc.net> ---
(In reply to comment #3)
> 
> No, upower/udisks are optional dependency. If they aren't available, some
> features just don't work or are disabled.
>

Yeah, well, xfce4-power-manager with upower is not really useful (it doesn't
parse /sys like xfce4-battery-plugin does).

>
> Further, it's up to the downstream
> package maintainers to encapsulate the battery plugin only in a separate
> package. I am talking mainly about merging the source to benefit from
> removing duplicated snippets.
> 

Thanks, I know the distinction between source and binary packages.

> 
> Again: The plugin should be kept as it is, only an idea to merge the source
> as such.
> 

But what's the point of that? They are different program, with little in
common, except their purpose: xfpm mostly uses gobject stuff and the upower
abstraction, so mostly it doesn't care about the platform. However,
battery-plugin uses good old structs and lots of #ifdefs for all the platform
it supports. So it doesn't look like you will remove many duplicate snippets...

> 
> Those users won't need to run Xfpm, and even not install the package with
> complete stuff if there's a package manager who knows what it does.
> 
> Although, I must say that I am not aware of the work amount needed to merge
> sources. But I can keep an eye on it.
>

Really, I don't think a folder called 'battery-plugin' inside xfpm would
improve anything, because they wouldn't share code unless you rewrite one of
them (e.g. have xfpm fall back to /sys parsing, let's not do that please).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.