[Goodies-dev] [Bug 9076] [PATCH] Run command to return network device to listen to

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=9076

Mike Massonnet <mmassonnet at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |mmassonnet at xfce.org
         Resolution|---                         |WONTFIX

--- Comment #1 from Mike Massonnet <mmassonnet at xfce.org> ---
Hi Miguel,

First to answer some of your comments in the patch.

/* enough? */
 => That's up to you, you provide the patch.

/* What is the XFCE way of dealing with null pointers */
 => There is no Xfce way, it's just C code.

Second about know the purpose of this patch.

The sanitizing part will only work for commands that return exactly what is
expected. The sanitizing part fails in case the output doesn't end with a new
line (\n). Can you cite a command that works for this patch? I don't see ip nor
ipconfig as an example. This may mean that the user needs to craft his own
script, which defeats the purpose of an option.

As a user it's impossible to guess what this new option is about.

Finally it's merely a duplicate of bug 3880, or bug 7431.

Your way of trying to discover the interface is not good enough, and is
therefore rejected.

Thank you for your report.

Regards,
Mike

-- 
You are receiving this mail because:
You are the QA Contact for the bug.