[Goodies-dev] [Bug 8316] Genmon doesn't like `&'

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Thu Feb 16 15:33:24 CET 2012


https://bugzilla.xfce.org/show_bug.cgi?id=8316

--- Comment #9 from John Lindgren <john.lindgren at aol.com> 2012-02-16 15:33:24 CET ---
I don't think this is the right approach.  The reason for expecting text
between the XML tags to be XML-encoded is not specifically to allow Pango
markup (though that is a cool side effect) but simply because you can't expect
to put raw text within XML without messing things up.  Certain characters (for
example, '&', '<', '>') have special meanings in XML; that's why they must be
escaped.

Summary: if you want to use the XML tags, you have to XML-encode your text.

The problem that needs fixing is that Genmon doesn't behave as it is
documented[1]: "If you want the plugin to display only text (original version),
enter the command in the Command field of the Property section of the plugin." 
My interpretation of this is, as I suggested before, that if there are no XML
tags in the input, then Genmon should assume that it is *not* XML-encoded.

The simple fix: change gtk_label_set_markup() to gtk_label_set_text(), but only
within the "if (newVersion == 0)" block.

[1] http://goodies.xfce.org/projects/panel-plugins/xfce4-genmon-plugin

-- 
Configure bugmail: https://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.


More information about the Goodies-dev mailing list