[Goodies-dev] [Bug 8659] New: Crash when tooltip longer than 256 bytes is provided by command

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=8659

          Priority: Medium
            Bug ID: 8659
          Assignee: frivoal at xfce.org
           Summary: Crash when tooltip longer than 256 bytes is provided
                    by command
        QA Contact: goodies-dev at xfce.org
          Severity: normal
    Classification: Panel Plugins
                OS: Linux
          Reporter: mathiasrav at gmail.com
          Hardware: PC (x86_64)
            Status: NEW
           Version: git
         Component: General
           Product: Xfce4-genmon-plugin

Created attachment 4309
  --> https://bugzilla.xfce.org/attachment.cgi?id=4309&action=edit
Change size of acToolTips from 256 to BUFMAX.

If a program outputs a tooltip longer than 256 bytes, a buffer in
DisplayCmdOutput of main.c is overflowed leading to a segmentation fault.

In DisplayCmdOutput in main.c, acToolTips is a 256-byte char array to hold the
tooltip provided by the external program. However, the program may provide as
much as 1024 bytes of XML output (since struct genmon_t::acValue is a 1024-byte
char array, a size which is passed to genmon_SpawnCmd), and the smaller buffer
size isn't honored when the tooltip is extracted in DisplayCmdOutput.

Attached patch that simply changes the size of acToolTips from 256 to BUFMAX
(same size used by genmon_t).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.