[Goodies-dev] [Bug 7804] Patch to show values of traffic on a panel plugin

[bugzilla-daemon at xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=7804

Mike Massonnet <mmassonnet at xfce.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #13 from Mike Massonnet <mmassonnet at xfce.org> 2011-12-27 16:21:12 CET ---
(In reply to comment #9)
> I reverted 
> +    gtk_label_set_width_chars(GTK_LABEL(global->monitor->rcv_label), 13);
> and
> +    gtk_label_set_width_chars(GTK_LABEL(global->monitor->snd_label), 13);
> for myself. Maybe we can use width less than 13?

It didn't bug me, but you are right, it's better to avoid this.


(In reply to comment #10)
> Created attachment 4045 [details]
> Updated patch to show values in panel.
> 
> * changed format_with_thousandssep into format_byte_humanreadable, used in
> labels and tooltip
> * set size of label (set to 10 chars for now)
> * set alignment of labels
> * fixed spelling mistakes in code
> 
> Problems/annoyances left:
> * check boxes are not a good choice anymore for bars/labels; a combobox would
> be much better here (only bars, only values, both)
> * do the new byte units (Byte, KiB,...) need translation?

One issue per bug, with attachment 4046, there is a change in the code with
regard to 'format_with_thousandssep' (with untranslatable strings). Please open
a new bug for this different issue.

This bug should only add the option "Show values". Once it will be pushed, the
commit will be marked in the log history with 'bug XXX: message'. This will
keep the history clean.

-- 
Configure bugmail: https://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.