[Goodies-dev] [Bug 5456] Icon unaccessible when XOAP error

bugzilla-daemon at xfce.org bugzilla-daemon at xfce.org
Wed Jun 17 23:39:32 CEST 2009


http://bugzilla.xfce.org/show_bug.cgi?id=5456





--- Comment #4 from Colin Leroy <colin at colino.net>  2009-06-17 21:39:32 UTC ---
My patch didn't remove the warning on failure to get the asked-for icon.
Instead, it loads 99.png after warning:

  image = gdk_pixbuf_new_from_file_at_scale (filename, size, size, TRUE, NULL);

  if (G_UNLIKELY (!image)) {
    g_warning ("Unable to open image: %s", filename); /* this is what you see
*/
    /* this checks that we asked for another image than the default "99"
    if (number && strcmp(number, "99")) {
      g_free(filename);
      /* and in this case it returns it. */
      return get_icon("99", size);
    }
  }

In the end, even with the warning, the icon should be displayed.

-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the Goodies-dev mailing list