[Goodies-dev] [Bug 4265] New: sensors plugin crash when trying to refresh ACPI FAN state

[bugzilla-daemon at xfce.org]

DO NOT REPLY TO THIS EMAIL.  Also, do not reply via email to the person
whose email is mentioned below.  To comment on this bug, please visit:
http://bugzilla.xfce.org/show_bug.cgi?id=4265

           Summary: sensors plugin crash when trying to refresh ACPI FAN
                    state
           Product: Xfce Panel Plugins
           Version: unspecified
          Platform: PC (x86)
               URL: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=491480
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: Medium
         Component: sensors
        AssignedTo: goodies-dev at xfce.org
        ReportedBy: corsac at debian.org


Hi,

a Debian user tracked down a crash in the acpi code, when refreshing fan state.
All details are in the Debian bug report, but basically get_acpi_value() takes
a full path while it's currently given a filename, so it returns NULL, and then
strcmp() crash on NULL.

He cooked a patch (which I attach) which fix the path problem, the check for
NULL before strcmp, and replaces strcmp() by strncmp() because on his box (and
maybe others) there's a \n after 'on' in the state file.

I just tested the patch on a box where /proc/acpi/fan exists, and it seems to
work fine.

Btw, is there an ETA for replacing every /proc code by the /sys one, now that
/proc/acpi begins to be deprecated?

Cheers and thanks,


-- 
Configure bugmail: http://bugzilla.xfce.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.